More updates for DI types philosophy #7916
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
May 18, 2017
security/access_denied_handler.rst
Outdated
| </services> | ||
| </container> | ||
| <config> | ||
| <firewall name="main"> |
There was a problem hiding this comment.
This cde uses 2-white space indentation. Should it be changed to 4?
security/api_key_authentication.rst
Outdated
|
|
||
| $container->loadFromExtension('security', array( | ||
| 'providers' => array( | ||
| 'api_key_user_provider' => array( |
There was a problem hiding this comment.
There are two white spaces before the arrow operator here -> 'api_key_user_provider' => array(
security/api_key_authentication.rst
Outdated
| @@ -682,65 +594,12 @@ current URL is before creating the token in ``createToken()``:: | |||
| // set the only URL where we should look for auth information | |||
| // and only return the token if we're at that URL | |||
| $targetUrl = '/login/check'; | |||
| if (!$this->httpUtils->checkRequestPath($request, $targetUrl)) { | |||
| if ($request->getPathInfo() != $targetUrl) | |||
There was a problem hiding this comment.
Can we use a strict checking here and replace != by !==?
service_container/alias_private.rst
Outdated
| What makes private services special is that, since the container knows that the | ||
| service will never be requested from outside, it can optimize whether and how it | ||
| is instanciated. This increases the container's performance. | ||
| Private services are special because it allows the container to optimize whether |
There was a problem hiding this comment.
because it allows the container [...] -> because they allow the container [...] ?
I didn't even realize! That's GREAT! Thanks for the review - I know these are a pain, but you're helping me continue to move quickly and get this done. Merged this into the 3.3 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
This is another big (sorry) PR for updating things for using type-hinting for injection. I only have a few directories remaining to review!
FYI, the following directories I'm not planning on reviewing, at least not right away (so, these are up for grabs!)
Thanks!